Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21731
to look at the new patch set (#13).
Change subject: [java][build] KUDU-3610: kudu-client.jar dependencies
......................................................................
[java][build] KUDU-3610: kudu-client.jar dependencies
As reported in KUDU-3610 Impala build fails with the newly generated
kudu-client.jar pom.xml.
The issue is in the pom generation itself [1], that is being done by
the 'maven-publish' plugin (which is necessary for gradle 7+ due to
the old publish plugin being deprecated).
This means that the content of the jars are correct, however the
generated pom.xml lists some dependencies in incorrect (maven) scopes.
The fix this change proposes is by editing the generated pom xml
structure, so that the shaded dependencies are removed from the
generated pom. This was previously done by the shadow plugin, however
due to API changes this is no longer possible and has to be done in
maven-publish plugin.
Additional manual testing (building Impala) was carried out that
confirmed that the pom is now correct.
[1]
https://discuss.gradle.org/t/maven-publish-plugin-generated-pom-making-dependency-scope-runtime/7494
Change-Id: I607d7c62c585b2aa1bee4ebf7907309e130092da
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client/build.gradle
3 files changed, 17 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/21731/13
--
To view, visit http://gerrit.cloudera.org:8080/21731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I607d7c62c585b2aa1bee4ebf7907309e130092da
Gerrit-Change-Number: 21731
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
