Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21731 )
Change subject: [java][build] KUDU-3610: kudu-client.jar dependencies ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/21731/14/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/21731/14/java/kudu-client/build.gradle@23 PS14, Line 23: implementation libs.protobufJava Since both AsyncKuduClient::trustedCertificates() and KuduClient::trustedCertificates() that you added in https://github.com/apache/kudu/commit/a0c0c44b91a795022eb46fd450d05e76acf3d718 have List<com.google.protobuf.ByteString> parameter, this should be now 'api', not 'implementation', right? Alternatively, there is still a chance to fix this and change com.google.protobuf.ByteString to some other common binary type to avoid exposing com.google.protobuf.ByteString as an API dependency for kuud-client JAR once it's released in upcoming Kudu 1.18.0 release. -- To view, visit http://gerrit.cloudera.org:8080/21731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607d7c62c585b2aa1bee4ebf7907309e130092da Gerrit-Change-Number: 21731 Gerrit-PatchSet: 14 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 22 Oct 2024 19:37:11 +0000 Gerrit-HasComments: Yes
