Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22056 )
Change subject: [subprocess] KUDU-3624 Fix DoWait thread-safety ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/22056/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22056/1//COMMIT_MSG@12 PS1, Line 12: EchoSubprocessTest.TestSubprocessMetricsOnError Add detail about how this fix was tested. Even better it is possible to adding unit test. http://gerrit.cloudera.org:8080/#/c/22056/1//COMMIT_MSG@15 PS1, Line 15: a check Add a one liner on what check fails. http://gerrit.cloudera.org:8080/#/c/22056/1//COMMIT_MSG@19 PS1, Line 19: unsucesful nit: unsuccessful http://gerrit.cloudera.org:8080/#/c/22056/1/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: http://gerrit.cloudera.org:8080/#/c/22056/1/src/kudu/util/subprocess.h@231 PS1, Line 231: nit: Remove this http://gerrit.cloudera.org:8080/#/c/22056/1/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: http://gerrit.cloudera.org:8080/#/c/22056/1/src/kudu/util/subprocess.cc@815 PS1, Line 815: std::unique_lock lock(wait_mutex_, std::try_to_lock); Why not move this to start of the function? -- To view, visit http://gerrit.cloudera.org:8080/22056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cb540860b439c26e1c8529123c8b29940d9f84f Gerrit-Change-Number: 22056 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Nov 2024 13:39:17 +0000 Gerrit-HasComments: Yes
