Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22056 )
Change subject: [subprocess] KUDU-3624 Fix DoWait thread-safety ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22056/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22056/2//COMMIT_MSG@15 PS2, Line 15: a the following http://gerrit.cloudera.org:8080/#/c/22056/1/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: http://gerrit.cloudera.org:8080/#/c/22056/1/src/kudu/util/subprocess.cc@815 PS1, Line 815: } > It is not used there. It's better to put near to the first point where it i What I meant was this - moving whole lock acquisition logic to the start so that we don't have to check for kExited state again. -- To view, visit http://gerrit.cloudera.org:8080/22056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cb540860b439c26e1c8529123c8b29940d9f84f Gerrit-Change-Number: 22056 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 14:42:19 +0000 Gerrit-HasComments: Yes
