Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22079 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/compaction-highmem-test.cc File src/kudu/tablet/compaction-highmem-test.cc: http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/compaction-highmem-test.cc@186 PS1, Line 186: FLAGS_memory_limit_warn_threshold_percentage = 0; : FLAGS_memory_pressure_percentage = 0; I just remembered that initialising limit flags here won't work because for a test binary, the initialisation of limits happens once during the first subtest execution. So if a sub test runs before this one, these limits will have already been initialised to default values. Hence this test will report as failed. As I tested this specific test individually, I didn't hit the failure error. I will rectify this shortly. -- To view, visit http://gerrit.cloudera.org:8080/22079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394 Gerrit-Change-Number: 22079 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 19:15:45 +0000 Gerrit-HasComments: Yes
