Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22079 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/22079/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22079/1//COMMIT_MSG@11 PS1, Line 11: that > nit: add comma after "that" Done http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/compaction-highmem-test.cc File src/kudu/tablet/compaction-highmem-test.cc: http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/compaction-highmem-test.cc@182 PS1, Line 182: s > nit: add period Done http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/compaction-highmem-test.cc@186 PS1, Line 186: FLAGS_memory_limit_warn_threshold_percentage = 0; : FLAGS_memory_pressure_percentage = 0; > I just remembered that initialising limit flags here won't work because for Done http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/delta_compaction.cc@132 PS1, Line 132: Delta Compaction > nit: change to lowercase? Change to a one word "MajorDeltaCompaction" as mentioned at other places. http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/delta_compaction.cc@227 PS1, Line 227: , > nit: remove comma and add "and" Done http://gerrit.cloudera.org:8080/#/c/22079/1/src/kudu/tablet/delta_compaction.cc@253 PS1, Line 253: be > nit: to be? Done -- To view, visit http://gerrit.cloudera.org:8080/22079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394 Gerrit-Change-Number: 22079 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 20:18:12 +0000 Gerrit-HasComments: Yes
