Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22058 )
Change subject: WIP [docs] add information on nullable array data block ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/22058/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22058/2//COMMIT_MSG@7 PS2, Line 7: array nit: This may have already been answered before, for my understanding - does this also consider possibility of multi-dimension arrays? If yes, it would be great if you can add an example to cover that case as well. http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md File docs/design-docs/cfile.md: http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@148 PS2, Line 148: format format for illustration http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@156 PS2, Line 156: 1101111 > Does this imply that only the third array is null? Meanwhile the flattened +1 If there is some bitwise operation logic applied here, it would help to add know-how about the same (at least in the comments section here) for posterity. http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@169 PS2, Line 169: 5,6,7,8 Can array elements be in random sequence or non-ascending order? http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@166 PS2, Line 166: | [2, 2) | {} | : | [2, 2) | null | : | [2, 4) | { 3,4 } | : | [4, 8) | { 5,6,7,8 } | : | [8, 9) | { null } | It would help to add a one liner definition for these (sort of a notation section): {} null { null } { 3,4 } -- To view, visit http://gerrit.cloudera.org:8080/22058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8972b3791d155e102240c80012e2b87192914cd1 Gerrit-Change-Number: 22058 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2024 15:48:11 +0000 Gerrit-HasComments: Yes
