Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22058 )
Change subject: WIP [docs] add information on nullable array data block ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md File docs/design-docs/cfile.md: http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@120 PS2, Line 120: flatten > nit: flattened Done http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@123 PS2, Line 123: similar > nit: similarly Done http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@128 PS2, Line 128: flatten > nit: flattened, likewise for all instances below here and in the examples. Done http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@148 PS2, Line 148: format > format for illustration Done http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@166 PS2, Line 166: | [2, 2) | {} | : | [2, 2) | null | : | [2, 4) | { 3,4 } | : | [4, 8) | { 5,6,7,8 } | : | [8, 9) | { null } | > Sure, I'll add this one even if it's easily deducible from the former examp Ah, that was a typo in the 'array start indices' field -- it should have been '0,1,1,1'. I fixed that and also changed '3,4' sequence into '4,2' :) -- To view, visit http://gerrit.cloudera.org:8080/22058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8972b3791d155e102240c80012e2b87192914cd1 Gerrit-Change-Number: 22058 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Sat, 23 Nov 2024 04:03:05 +0000 Gerrit-HasComments: Yes
