Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22133 )

Change subject: KUDU-3571: fix flakiness in 
AutoIncrementingItest.BootstrapNoWalsNoData
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22133/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22133/1//COMMIT_MSG@10
PS1, Line 10: lagging replicas, thus return
> I noticed that scan requests failed because some operations are not applied
It should become deterministic if you reduce heartbeat interval to say 10 and 
also add sleep of 10 ms to InsertData() as following:
ASSERT_OK(InsertData(kNumRows, kNumRows * 2, 10));

I guess just these two line changes should be enough to make this test work 
deterministically.
No need to have ScanTable() in the first place.
You might not even require to call WaitForTabletsRunning().

You can validate the deterministic outcome by running the test for say 100 
times.



--
To view, visit http://gerrit.cloudera.org:8080/22133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bd387c82b632dbb77aa5a45f831273392ae05b4
Gerrit-Change-Number: 22133
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Thu, 28 Nov 2024 14:46:34 +0000
Gerrit-HasComments: Yes

Reply via email to