Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22133 )
Change subject: KUDU-3571: fix flakiness in AutoIncrementingItest.BootstrapNoWalsNoData ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Overall looks good to me. Just a couple minor comments. http://gerrit.cloudera.org:8080/#/c/22133/4/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/22133/4/src/kudu/integration-tests/auto_incrementing-itest.cc@82 PS4, Line 82: kRaftHeartbeatIntervalMs = 10 Can this be made applicable to just one test i.e. BootstrapNoWalsNoData ? And all other tests in this file can have default value for BootstrapNoWalsNoData. http://gerrit.cloudera.org:8080/#/c/22133/4/src/kudu/integration-tests/auto_incrementing-itest.cc@442 PS4, Line 442: replicated nit: are replicated -- To view, visit http://gerrit.cloudera.org:8080/22133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bd387c82b632dbb77aa5a45f831273392ae05b4 Gerrit-Change-Number: 22133 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 02 Dec 2024 10:11:01 +0000 Gerrit-HasComments: Yes
