Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )
Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22159/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22159/2//COMMIT_MSG@13 PS2, Line 13: future proof Could you also mention that another reason is the presence of issues like https://issues.apache.org/jira/browse/THRIFT-5599 and https://issues.apache.org/jira/browse/THRIFT-5696 in 0.16.0 at least? THRIFT-5599 would lead to a build error if upgrading to 0.16.0, so 0.16.0 is a no-go unless we'd like to have an extra patch on top of stock Thrift 0.16.0 release. http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh@1012 PS2, Line 1012: -DWITH_ZLIB=ON Do we really use ZLIB support in thrift? I compiled it with -DWITH_ZLIB=OFF and everything seems working OK so far. With ZLIB support, we do compile one extra library libthriftz in 3rd-party, but I don't think we use it anywhere in the code anyway. -- To view, visit http://gerrit.cloudera.org:8080/22159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5 Gerrit-Change-Number: 22159 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 03 Dec 2024 21:17:07 +0000 Gerrit-HasComments: Yes
