Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22159 )
Change subject: [thirdparty] KUDU-3626: Upgrade Apache Thrift to version 0.21.0 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/22159/2/thirdparty/build-definitions.sh@1012 PS2, Line 1012: -DWITH_ZLIB=ON > I didn't find any usages of zlib in our codebase hence disabled it. Thanks for the confirmation I guess -DWITH_ZLIB=ON means it's enabled. Or you are going to update this with a new patchset soon? -- To view, visit http://gerrit.cloudera.org:8080/22159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44c85f5d6679895865346118759d8da379cec3d5 Gerrit-Change-Number: 22159 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Dec 2024 07:03:22 +0000 Gerrit-HasComments: Yes
