Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22132 )
Change subject: KUDU-613: Don't modify refs when moving entries ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22132/4/src/kudu/util/slru_cache.cc File src/kudu/util/slru_cache.cc: http://gerrit.cloudera.org:8080/#/c/22132/4/src/kudu/util/slru_cache.cc@321 PS4, Line 321: handle->refs.store(2, std::memory_order_relaxed); > Is this still required once the new code stopped updating the reference cou Yep this is still necessary. The use case of ProtectedInsert is for the update case in the protected segment. A new handle is being inserted here, so one ref for the shard and one ref for the returned handle, similar to the Insert() method for the probationary segment. That being said, the refs are updated here properly so I don't think this is the issue you bring up in your second sentence. -- To view, visit http://gerrit.cloudera.org:8080/22132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I643907612d43eba2c5f8dbc19d2f74f88bbca869 Gerrit-Change-Number: 22132 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2024 21:56:59 +0000 Gerrit-HasComments: Yes
