Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22132 )
Change subject: KUDU-613: Don't modify refs when moving entries ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22132/4/src/kudu/util/slru_cache.cc File src/kudu/util/slru_cache.cc: http://gerrit.cloudera.org:8080/#/c/22132/4/src/kudu/util/slru_cache.cc@311 PS4, Line 311: vector<SLRUHandle*> evicted_entries; > We should try to fully remove this vector and if not possible, reserve some This will be taken up in a subsequent patch. -- To view, visit http://gerrit.cloudera.org:8080/22132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I643907612d43eba2c5f8dbc19d2f74f88bbca869 Gerrit-Change-Number: 22132 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2024 20:07:04 +0000 Gerrit-HasComments: Yes
