Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22164 )
Change subject: KUDU-613: Vector optimizations ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22164/1/src/kudu/util/slru_cache.cc File src/kudu/util/slru_cache.cc: http://gerrit.cloudera.org:8080/#/c/22164/1/src/kudu/util/slru_cache.cc@508 PS1, Line 508: protected_shard_.InsertAndReturnEvicted(val_handle, &evictions); > Can you instead just use a fixed-size stack array here and call InsertAndRe Just for visibility: I don’t think I quite get it. InsertAndReturnEvicted is called when an entry is being upgraded. Within the function the entry is added to the protected segment, then it adds any to-be-evicted entries to the return vector to be processed later. Calling InsertAndReturnEvicted in a loop would mean we’re upgrading multiple entries. -- To view, visit http://gerrit.cloudera.org:8080/22164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cb24b05724fdf5c1e975ac83c0cdc23c51f9f36 Gerrit-Change-Number: 22164 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2024 00:42:24 +0000 Gerrit-HasComments: Yes
