Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22164 )
Change subject: KUDU-613: Vector optimizations ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22164/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22164/1//COMMIT_MSG@16 PS1, Line 16: The method 'InsertAndReturnEvicted' returns a : vector with the evicted entries. Rather than : returning a copy of the vector, the vector of : evicted entries is now a parameter to the function : so it's passed by pointer. > +1 For visibility, I posted a patch to remove the use of vectors: https://gerrit.cloudera.org/c/22181/ -- To view, visit http://gerrit.cloudera.org:8080/22164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cb24b05724fdf5c1e975ac83c0cdc23c51f9f36 Gerrit-Change-Number: 22164 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2024 23:50:35 +0000 Gerrit-HasComments: Yes
