Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22079 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22079/3/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/3/src/kudu/tablet/delta_compaction.cc@221 PS3, Line 221: << CompactionInputRowToString(*input_row); > This statement is not updating memory tracker. Instead, it just stores the At L142, we check the value of mem_consumed before updating the memory tracker, do we also need to calculate the memory difference? Also, at L195 and L232, the memory tracker is updated twice, could we update it after calling ApplyMutationsAndGenerateUndos? http://gerrit.cloudera.org:8080/#/c/22079/4/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/4/src/kudu/tablet/delta_compaction.cc@132 PS4, Line 132: MajorDeltaCompaction op may not complete due to lack of sufficient memory It is not very clear what this warning message is for. Maybe it should be used to warn that MajorDeltaCompaction ops may lead to insufficient memory. -- To view, visit http://gerrit.cloudera.org:8080/22079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394 Gerrit-Change-Number: 22079 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2024 09:59:34 +0000 Gerrit-HasComments: Yes
