Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22079 )

Change subject: [compaction] Add memory tracking for better OOM issues triaging
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 5:
>
> (1 comment)
>
> Could you at least rebase this patch on top of HEAD in the master branch?
>
> Since pre-commit Jenkins jobs are re-using workspaces between builds, any 
> updates on this patch continue to pollute workspaces and lead to build 
> failures.

Done

http://gerrit.cloudera.org:8080/#/c/22079/3/src/kudu/tablet/delta_compaction.h
File src/kudu/tablet/delta_compaction.h:

http://gerrit.cloudera.org:8080/#/c/22079/3/src/kudu/tablet/delta_compaction.h@20
PS3, Line 20: #include <cstdint>
> nit: remove the extra line, and move <cstdint> include to be alphabetically
Done



--
To view, visit http://gerrit.cloudera.org:8080/22079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394
Gerrit-Change-Number: 22079
Gerrit-PatchSet: 6
Gerrit-Owner: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Thu, 19 Dec 2024 09:40:44 +0000
Gerrit-HasComments: Yes

Reply via email to