Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22079 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/22079/9/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/9/src/kudu/tablet/delta_compaction.cc@193 PS9, Line 193: // Update memory tracker with memory allocated for mutations. > OK, them maybe then get rid of those 'if(...)' in the code and just call 'U Done http://gerrit.cloudera.org:8080/#/c/22079/9/src/kudu/tablet/delta_compaction.cc@271 PS9, Line 271: for (const DeltaKeyAndUpdate& key_and_update : out) { > OK, but then why to account for Arena's memory usage above at lines 237 and I guess it wouldn't harm to account memory usage from here as well. http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_compaction.cc@131 PS10, Line 131: msg > Why to spend CPU cycles and memory to build 'msg' here if it's only needed Moved inside. http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_compaction.cc@255 PS10, Line 255: UpdateMemTracker(mem.arena.memory_footprint()); Forgot to negate the memory footprint value since this memory is to be released below. Fixed now. http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_store.h File src/kudu/tablet/delta_store.h: http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_store.h@482 PS10, Line 482: auto delta > Would 'const auto& delta' be a better option here to avoid extra copying? Indeed! Thanks for pointing out. -- To view, visit http://gerrit.cloudera.org:8080/22079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394 Gerrit-Change-Number: 22079 Gerrit-PatchSet: 10 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 23 Jan 2025 07:39:38 +0000 Gerrit-HasComments: Yes
