Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22079 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_compaction.cc@130 PS10, Line 130: if (process_memory::UnderMemoryPressure(&capacity_pct)) { > OK, since this looks rather a warning about possible OOM condition per clar The main reason behind comparing the current consumption against memory_limit_warn_threshold_percentage is to ensure we start emitting warning messages before breaching hard limit. Memory pressure method is only to get capacity_pct (default: 90% of hard limit). "Under memory pressure" condition being true is a pre-requisite for "crossing memory_limit_warn_threshold_percentage" so it doesn't harm to use the method to get capacity_pct. Isn't it better to receive such warnings early on rather than late when hard limit has already been crossed? I am not fully convinced with using hard limit directly, unless I am missing core message from your comment. -- To view, visit http://gerrit.cloudera.org:8080/22079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394 Gerrit-Change-Number: 22079 Gerrit-PatchSet: 11 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 23 Jan 2025 13:43:13 +0000 Gerrit-HasComments: Yes
