Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22079 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/10/src/kudu/tablet/delta_compaction.cc@130 PS10, Line 130: if (process_memory::UnderMemoryPressure(&capacity_pct)) { > AFAIK, in non-cgroup case, the OOM killer isn't about the exact amount of m Yes, OOM killer picking up a process at any consumption % (with highest badness score) is a possibility and there is not much that can be done gauge that. Interesting read on OOM and cgroups: https://lwn.net/Articles/761118/ (not sure if this was inducted in mainline kernel). #2 option with 1 second interval seems fine to me. http://gerrit.cloudera.org:8080/#/c/22079/11/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/22079/11/src/kudu/tablet/delta_compaction.cc@133 PS11, Line 133: "MajorDeltaCompaction op may not complete due to lack of sufficient memory " : "(at %.2f%% of capacity), current compaction consumption: %ld, total consumption " : "for all running major delta compaction ops: %ld, tablet: %s" > Looks better, but I'd make it a bit more concise. Maybe, something similar Yes, similar accounting and logging for merge rowset compaction in a separate change. -- To view, visit http://gerrit.cloudera.org:8080/22079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394 Gerrit-Change-Number: 22079 Gerrit-PatchSet: 13 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2025 12:59:52 +0000 Gerrit-HasComments: Yes
