Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22079 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 16: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/22079/16/src/kudu/tablet/compaction-highmem-test.cc File src/kudu/tablet/compaction-highmem-test.cc: http://gerrit.cloudera.org:8080/#/c/22079/16/src/kudu/tablet/compaction-highmem-test.cc@244 PS16, Line 244: const Alright, constexpr would be better, but const is OK for a test, I guess. 16 revisions for quite small and trivial patch is too many, indeed :) http://gerrit.cloudera.org:8080/#/c/22079/14/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: http://gerrit.cloudera.org:8080/#/c/22079/14/src/kudu/util/process_memory.cc@69 PS14, Line 69: (arain > For normal scenarios, 1/100 granularity may suffice but this is mainly for Alright: given this flag is a temporary one until KUDU-3429 is addressed, it should be OK for now. -- To view, visit http://gerrit.cloudera.org:8080/22079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2037582d433730884212e83359bb75bad0d5394 Gerrit-Change-Number: 22079 Gerrit-PatchSet: 16 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2025 04:48:24 +0000 Gerrit-HasComments: Yes
