Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22420 )
Change subject: KUDU-3639 Add REST-compatible table operation functions ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22420/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/22420/1/src/kudu/master/catalog_manager.cc@1909 PS1, Line 1909: user.emplace(rpc.value()->remote_user().username()); > Is this log needed? Done http://gerrit.cloudera.org:8080/#/c/22420/1/src/kudu/master/catalog_manager.cc@1949 PS1, Line 1949: ship. > Is it ok to wait forever here? In WaitForNotificationLogListenerCatchUp, WaitForCatchUp is called with rpc->GetClientDeadline(). Looking at the GetClientDeadline() it says in the code: If the client did not specify a deadline, returns MonoTime::Max(). Since this is the default, I used it in case there isn't RPC context available. http://gerrit.cloudera.org:8080/#/c/22420/1/src/kudu/master/catalog_manager.cc@3453 PS1, Line 3453: user.emplace(rpc.value()->remote_user().username()); > Is this important to log on INFO level? Done -- To view, visit http://gerrit.cloudera.org:8080/22420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If52359603e3aa8af2dedc41ecc5eb78d03151fe5 Gerrit-Change-Number: 22420 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 09:45:08 +0000 Gerrit-HasComments: Yes
