Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22420 )
Change subject: KUDU-3639 Add REST-compatible table operation functions ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22420/1/src/kudu/master/catalog_manager-test.cc File src/kudu/master/catalog_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/22420/1/src/kudu/master/catalog_manager-test.cc@339 PS1, Line 339: req.mutable_table()->set_table_name("test_table"); : CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager()); : ASSERT_OK(master_->catalog_manager()->DeleteTableRpc(req, &resp, nullptr)); : } : : TEST_F(CatalogManagerTest, TestDeleteTableWithUser) { : CreateTestTable(); : DeleteTableRequestPB req; : DeleteTableResponsePB resp; : req.mutable_table()->set_table_name("test_table"); : CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager()); : const string user = "test_user"; : ASSERT_OK(master_->catalog_manager()->DeleteTableWithUser(req, &resp, user)); : } : : TEST_F(CatalogManagerTest, TestCreateTableRpc) { : CreateTableRequestPB req; : CreateTableResponsePB resp; : CreateTableTest(req, resp); : CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager()); : ASSERT_OK(master_->catalog_manager()->CreateTable(&req, &resp, nullptr)); : } : : TEST_F(CatalogManagerTest, TestCreateTableWithUser) { : CreateTableRequestPB req; : CreateTableResponsePB resp; : CreateTableTest(req, resp); : CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager()); : const string user = "test_user"; : ASSERT_OK(master_->catalog_manager()->CreateTableWithUser(&req, &resp, user)); : } : : TEST_F(CatalogManagerTest, TestAlterTableRpc) { : CreateTestTable(); : AlterTableRequestPB req; : > Please make a shared function. Done -- To view, visit http://gerrit.cloudera.org:8080/22420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If52359603e3aa8af2dedc41ecc5eb78d03151fe5 Gerrit-Change-Number: 22420 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 09:45:30 +0000 Gerrit-HasComments: Yes
