Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22314 )
Change subject: KUDU-3563 Output tablet-level metrics in Prometheus ...................................................................... Patch Set 11: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22314/7/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/22314/7/src/kudu/tablet/tablet_metrics.cc@129 PS7, Line 129: "to the Scanner Cells Returned metric." > I think space is not needed here. I checked the other metrics definitions a If there isn't a space there, it results in a garbled description, where the 'Note ...' sentence if glued to the prior part of the message. Did you check out how the result looks at https://kudu.apache.org/docs/metrics_reference.html when the spaces are missed? -- To view, visit http://gerrit.cloudera.org:8080/22314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af Gerrit-Change-Number: 22314 Gerrit-PatchSet: 11 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Mon, 03 Feb 2025 16:21:15 +0000 Gerrit-HasComments: Yes
