Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22314 )
Change subject: KUDU-3563 Output tablet-level metrics in Prometheus ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22314/7/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/22314/7/src/kudu/tablet/tablet_metrics.cc@129 PS7, Line 129: "to the Scanner Cells Returned metric." > If there isn't a space there, it results in a garbled description, where th Done http://gerrit.cloudera.org:8080/#/c/22314/7/src/kudu/tablet/tablet_metrics.cc@141 PS7, Line 141: "to the Scanner Bytes Returned metric." > I think space is not needed here. I checked the other metrics definitions a Done -- To view, visit http://gerrit.cloudera.org:8080/22314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af Gerrit-Change-Number: 22314 Gerrit-PatchSet: 7 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Mon, 03 Feb 2025 17:13:50 +0000 Gerrit-HasComments: Yes
