Hello Marton Greber, Zoltan Martonka, Alexey Serbin, Attila Bukor, Kudu
Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22491
to look at the new patch set (#8).
Change subject: [java] code cleanup
......................................................................
[java] code cleanup
Small changes aiming to do some cleanup of the Java codebase.
The introduced modifications:
* removed unnecessary initialisations (def values, and empty ArrayLists)
* added the 'frozen' field to PartialRow's copy constructor
* switched a '==' comparison to .equals()
* switched to Files.delete[IfExists] instead of simple .delete() call
* replaced concatenated log messages with parameterised ones
Change-Id: Iedaf7ffb0689f4c190fd585e73687b9c6c668890
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduMetrics.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/BigLinkedListCommon.java
M
java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/log/LoggingTestMain.java
M
java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
14 files changed, 17 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/22491/8
--
To view, visit http://gerrit.cloudera.org:8080/22491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iedaf7ffb0689f4c190fd585e73687b9c6c668890
Gerrit-Change-Number: 22491
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
