Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22491 )
Change subject: [java] code cleanup ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/22491/8/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: http://gerrit.cloudera.org:8080/#/c/22491/8/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java@640 PS8, Line 640: int inflightMessagesNum; > Odd that line 639 was changed but not line 640? Done http://gerrit.cloudera.org:8080/#/c/22491/7/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/BigLinkedListCommon.java File java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/BigLinkedListCommon.java: http://gerrit.cloudera.org:8080/#/c/22491/7/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/BigLinkedListCommon.java@182 PS7, Line 182: for (long bits = nextLong(); n-- != 0; bits >>>= 8) { > One less line if we change this line to "int n = Math.min(i, 8)"? Done -- To view, visit http://gerrit.cloudera.org:8080/22491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedaf7ffb0689f4c190fd585e73687b9c6c668890 Gerrit-Change-Number: 22491 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 10 Mar 2025 13:47:29 +0000 Gerrit-HasComments: Yes
