Hello Marton Greber, Ashwani Raina, Attila Bukor, Kudu Jenkins, Abhishek
Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22573
to look at the new patch set (#5).
Change subject: KUDU-3646 fix Base64Decode()
......................................................................
KUDU-3646 fix Base64Decode()
Prior to this patch, Base64Decode() in src/kudu/util/url-coding.cc
had a bug that lead to truncating the output data by discarding
trailing null/zero bytes.
Originally imported from the Impala's codebase [1], the bug has been
lurking for 11+ years in the Kudu's codebase. Meanwhile, Impala fixed
the issue a long time ago [2].
This patch addresses the issue and adds corresponding test coverage.
In addition, this patch adds extra validation for the input of
Base64Decode() and provides test coverage for that as well.
Also, reference binding to null pointer in url-coding-test.cc has been
addressed as well.
[1] https://github.com/apache/kudu/commit/ce4d760ca
[2] https://issues.apache.org/jira/browse/IMPALA-2878
Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc
---
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.cc
M src/kudu/util/url-coding.h
3 files changed, 132 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/22573/5
--
To view, visit http://gerrit.cloudera.org:8080/22573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc
Gerrit-Change-Number: 22573
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
