Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22573 )
Change subject: KUDU-3646 fix Base64Decode() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22573/3/src/kudu/util/url-coding-test.cc File src/kudu/util/url-coding-test.cc: http://gerrit.cloudera.org:8080/#/c/22573/3/src/kudu/util/url-coding-test.cc@133 PS3, Line 133: ASSERT_FALSE(Base64Decode("====", &out)); > Thank you for taking a look at this. I tried to add that one, and surprisi Follow-up: after some consideration, I updated the code to handle such cases as well. -- To view, visit http://gerrit.cloudera.org:8080/22573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc Gerrit-Change-Number: 22573 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 06 Mar 2025 02:52:17 +0000 Gerrit-HasComments: Yes
