Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22708 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22708/3/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/22708/3/src/kudu/tablet/compaction.cc@305 PS3, Line 305: RETURN_NOT_OK(redo_delta_iter_->PrepareBatch( : block_.nrows(), DeltaIterator::PREPARE_FOR_COLLECT)); Just to make sure, in case of all 3 calls, If status != ok, then no additional memory allocated, and you don't need to update memory tracker, right? -- To view, visit http://gerrit.cloudera.org:8080/22708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I700fdf5ee0fbf0f2826b863d23d599f03ad4ac49 Gerrit-Change-Number: 22708 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 10 Apr 2025 11:22:31 +0000 Gerrit-HasComments: Yes
