Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22708 )
Change subject: [compaction] Add memory tracking for better OOM issues triaging ...................................................................... [compaction] Add memory tracking for better OOM issues triaging This patch adds memory accounting for RowSet compaction. The memory usage is tracked under newly added MemTracker. The tracker is added per rowset compaction operation. The same tracker is shared across multiple compaction inputs that are involved in that specific compaction operation. Each input has its own usage added to shared memory tracker during the initialisation and is deducted in corresponding destructor. Along with that, throttled warning messages are added when the memory usage goes beyond a certain threshold. A unit test is added to verify the presence of warning messages when memory threshold (reduced for test purpose) is crossed. Change-Id: I700fdf5ee0fbf0f2826b863d23d599f03ad4ac49 Reviewed-on: http://gerrit.cloudera.org:8080/22708 Reviewed-by: Zoltan Martonka <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Marton Greber <[email protected]> --- M src/kudu/tablet/compaction-highmem-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/compaction.h M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet.cc 13 files changed, 229 insertions(+), 40 deletions(-) Approvals: Zoltan Martonka: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I700fdf5ee0fbf0f2826b863d23d599f03ad4ac49 Gerrit-Change-Number: 22708 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
