Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22806 )
Change subject: KUDU-3661 Ranger policy not honored in Kudu ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/22806/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22806/2//COMMIT_MSG@7 PS2, Line 7: KUDU-3661 > nit: drop this since JIRA ID should be enough already? Done http://gerrit.cloudera.org:8080/#/c/22806/2//COMMIT_MSG@19 PS2, Line 19: Change-Id: I635132154d622eb41e993a0 > To me it looks quite straightforward. At least, with the following patch t Ah okay, so basically the idea is to ensure 2 actions are present and we are not prematurely exiting where one actions is SELECT and the other is any available action. Makes sense. Thanks Alexey http://gerrit.cloudera.org:8080/#/c/22806/2/src/kudu/master/ranger_authz_provider.cc File src/kudu/master/ranger_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/22806/2/src/kudu/master/ranger_authz_provider.cc@286 PS2, Line 286: unordered_set > BTW, using unordered_set here isn't a good idea from performance perspectiv Yes, agreed. http://gerrit.cloudera.org:8080/#/c/22806/2/src/kudu/master/ranger_authz_provider.cc@315 PS2, Line 315: // If select is allowed, we need to worry about column level privileges. > nit: add a comment to explain why the control returns out of the function h Done -- To view, visit http://gerrit.cloudera.org:8080/22806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I635132154d622eb41e993a0a1a818b21b5af6bb7 Gerrit-Change-Number: 22806 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 23 Apr 2025 21:23:22 +0000 Gerrit-HasComments: Yes
