Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22806 )
Change subject: KUDU-3661 Ranger policy not honored in Kudu ...................................................................... Patch Set 3: (4 comments) > Build Failed > > http://jenkins.kudu.apache.org/job/pre_commit/1303/ : FAILURE IWYU isn't yet happy: >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/build_and_test/src/kudu/ranger/ranger_client-test.cc' @@ -18,6 +18,7 @@ #include "kudu/ranger/ranger_client.h" #include <cstddef> +#include <initializer_list> #include <memory> #include <string> #include <unordered_map> IWYU would have edited 1 files on your behalf. make[3]: *** [CMakeFiles/iwyu] Error 1 http://gerrit.cloudera.org:8080/#/c/22806/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22806/2//COMMIT_MSG@19 PS2, Line 19: Change-Id: I635132154d622eb41e993a0 > Ah okay, so basically the idea is to ensure 2 actions are present and we ar Having just 2 allowed actions is the easiest way to expose that, yes. There could be a fuzzy-style w.r.t. the allowed actions which would expose the bug right away, but nobody added such one. So, adding a simplest scenario to expose this bug and protect against future regressions looks like a good enough approach to me in this context. http://gerrit.cloudera.org:8080/#/c/22806/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22806/3//COMMIT_MSG@12 PS3, Line 12: an : unordered_set<ActionPB, ActionHash> named actions unordered_set<ActionPB, ActionHas> container http://gerrit.cloudera.org:8080/#/c/22806/3/src/kudu/master/ranger_authz_provider.cc File src/kudu/master/ranger_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/22806/3/src/kudu/master/ranger_authz_provider.cc@315 PS3, Line 315: we need to worry about column level privileges It's vice-versa, actually, so that's why this early return. Maybe, replace the selected text with: there isn't a need to check against column-level privileges http://gerrit.cloudera.org:8080/#/c/22806/3/src/kudu/ranger/ranger_client-test.cc File src/kudu/ranger/ranger_client-test.cc: http://gerrit.cloudera.org:8080/#/c/22806/3/src/kudu/ranger/ranger_client-test.cc@343 PS3, Line 343: FatFingerTypo Maybe, rename this into KUDU3661 or something similar instead of fun-generic FatFingerTypo. -- To view, visit http://gerrit.cloudera.org:8080/22806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I635132154d622eb41e993a0a1a818b21b5af6bb7 Gerrit-Change-Number: 22806 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 23 Apr 2025 22:54:39 +0000 Gerrit-HasComments: Yes
