Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22779 )
Change subject: Add /api/v1/leader endpoint to REST API endpoints ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22779/2/src/kudu/master/rest_catalog-test.cc File src/kudu/master/rest_catalog-test.cc: http://gerrit.cloudera.org:8080/#/c/22779/2/src/kudu/master/rest_catalog-test.cc@561 PS2, Line 561: string leader_addr; : for (int i = 0; i < cluster_->num_masters(); i++) { : EasyCurl c; : faststring buf; : ASSERT_OK(c.FetchURL(Substitute("http://$0/api/v1/leader";, : cluster_->mini_master(i)->bound_http_addr().ToString()), : &buf)); : vector<string> matches; : KuduRegex re("\"leader\":\"([^\"]+)\"", 1); : if (re.Match(buf.ToString(), &matches)) { : leader_addr = matches[0]; : break; : } : } : : ASSERT_FALSE(leader_addr.empty()); I guess we could do a bit more assertion: get the leader addresses from all 3 masters. make sure that all 3 returned addresses are the same. Then just pick one and perform a basic fetch on that address. -- To view, visit http://gerrit.cloudera.org:8080/22779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If74db14bee2d273529ebfb02e72c6675bb094bce Gerrit-Change-Number: 22779 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 24 Apr 2025 10:24:43 +0000 Gerrit-HasComments: Yes
