Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22779 )
Change subject: Add /api/v1/leader endpoint to REST API endpoints ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22779/4/src/kudu/master/rest_catalog_path_handlers.cc File src/kudu/master/rest_catalog_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/22779/4/src/kudu/master/rest_catalog_path_handlers.cc@192 PS4, Line 192: if (master.has_error()) { : continue; : } : : if (master.role() != RaftPeerPB::LEADER) { : continue; : } maybe combine these two conditions together with and or -- To view, visit http://gerrit.cloudera.org:8080/22779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If74db14bee2d273529ebfb02e72c6675bb094bce Gerrit-Change-Number: 22779 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 05 May 2025 13:25:40 +0000 Gerrit-HasComments: Yes
