Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22858 )
Change subject: KUDU-3662 [1/n] Set up Flink-based replication ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22858/2/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: http://gerrit.cloudera.org:8080/#/c/22858/2/java/gradle/dependencies.gradle@35 PS2, Line 35: 1.19.1 Do we want to use the 2.0.0 version? Not sure what the changes are but if upgrading in future, it might be a bigger task to do major version upgrades. https://github.com/apache/flink/tags http://gerrit.cloudera.org:8080/#/c/22858/2/java/kudu-replication/build.gradle File java/kudu-replication/build.gradle: http://gerrit.cloudera.org:8080/#/c/22858/2/java/kudu-replication/build.gradle@21 PS2, Line 21: implementation Maybe too early, but are we planning to shade the flink dependency? If so, consider maybe using api dependency configuration. -- To view, visit http://gerrit.cloudera.org:8080/22858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie68458eb5079fa225d3a748ce8f9a6db8e7a724c Gerrit-Change-Number: 22858 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Sat, 10 May 2025 00:33:05 +0000 Gerrit-HasComments: Yes
