Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22858 )
Change subject: KUDU-3662 [1/n] Set up Flink-based replication ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22858/2/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: http://gerrit.cloudera.org:8080/#/c/22858/2/java/gradle/dependencies.gradle@35 PS2, Line 35: 1.19.1 > Do we want to use the 2.0.0 version? Not sure what the changes are but if u A bit of background info: I think the main thing to consider here is the flink-connector-kudu. There has been changes in the Flink connector api. But the flink-connector-kudu already is up to date. So I think we should be fine in the future. For now I would stick to the Flink version that is pinned in the flink-connector-kudu: https://github.com/apache/flink-connector-kudu/blob/eb13082fc75a0061a1605c92f536157b4ac8a5b0/pom.xml#L55 -> 1.19.2 so I think we should use this version. http://gerrit.cloudera.org:8080/#/c/22858/2/java/kudu-replication/build.gradle File java/kudu-replication/build.gradle: http://gerrit.cloudera.org:8080/#/c/22858/2/java/kudu-replication/build.gradle@21 PS2, Line 21: implementation > Maybe too early, but are we planning to shade the flink dependency? If so, Some Flink dependencies should not be shaded: https://nightlies.apache.org/flink/flink-docs-release-2.0/docs/dev/configuration/overview/ For now I would just put a todo here about shading, and we will look into this once all the pieces are there and we have a better picture. -- To view, visit http://gerrit.cloudera.org:8080/22858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie68458eb5079fa225d3a748ce8f9a6db8e7a724c Gerrit-Change-Number: 22858 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 12 May 2025 08:37:11 +0000 Gerrit-HasComments: Yes
