Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/22768/17/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/17/java/kudu-client/build.gradle@42 PS17, Line 42: api libs.netty Here and elsewhere with the dependency type changing to 'api' in recent patch sets: I'm not sure this should be of the 'api' type, at least for the 'libs.netty' in 'kudu-client' package. IIUC, 'api' in this case means that 'kudu-client' exposes at least one class from libs.netty either in its public method's parameters, return type, or type used in parent classes or interfaces. Basically, 'api' here means that at least one of the Netty's classes is a part of the kudu-client ABI. If that's indeed so, then which Netty's class is that? I couldn't find any by looking into the kudu-client API docs and into a few files in kudu-client, but I might be missing something. Could you clarify on this, please? The same question stands for other dependencies that are now of the 'api' type here in kudu-client and other build.gradle files in PS17. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/22768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0 Gerrit-Change-Number: 22768 Gerrit-PatchSet: 17 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 13 May 2025 00:01:02 +0000 Gerrit-HasComments: Yes
