Zoltan Chovan has posted comments on this change. (
http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18:
(1 comment)
> Patch Set 17:
>
> > Patch Set 16:
> >
> > As discussed offline, the jars need to be validated if they contain the
> > needed jars. For example the kudu-client.jar is missing a few classes from
> > netty project:
> >
> > [root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.17.1.jar | grep
> > "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
> > 1
> > 1 com
> > 2042 com google
> > 1 io
> > 412 io micrometer
> > 6 com sangupta
> > 684 com google
> > 1 org
> > 422 org checkerframework
> > 98 org HdrHistogram
> > 23 org LatencyUtils
> > 3139 io netty
> > [root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.18.0-SNAPSHOT.jar |
> > grep "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
> > 1
> > 1 com
> > 2776 com google
> > 1 io
> > 412 io micrometer
> > 6 com sangupta
> > 3 com google
> > 1 org
> > 18 org checkerframework
> > 62 org HdrHistogram
> > 20 org LatencyUtils
> > 1107 io netty
>
> I'm looking into this, at a first glance, the versions of netty is different
> between 1.17.1 and the tip of master, it is 4.1.110.Final and 4.1.115.Final
> respectively. I'm not sure if the difference can simply be explained by this.
> Will look into it further.
I've done some more investigation on this. Turns out that this is due to
calling 'minimize()' in the kudu-client module's shadowJar section. This
basically excludes all not used classes from making it into the generated jar.
see: https://gradleup.com/shadow/configuration/minimizing/
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG@17
PS17, Line 17: Additionally, the skipping of publishing wasn't working, this
needed to
: be fixed for the following modules (to keep in alignment with
pre-gradle
: upgrade behaviour):
: * kudu-backup-common
: * kudu-jepsen
: * kudu-proto
: * kudu-subprocess
:
: Fixed the generated jar names of the following modules:
: * kudu-backup -> kudu-backup3_2.12
: * kudu-spark -> kudu-spark3_2.12
: * kudu-spark-tools -> kudu-spark3-tools_2.12
> Does it make sense to moving these items into a separate changelist, while
I wanted this changelist to fix all issues related to publishing to avoid more
review cycles. I can separate them, but I feel like I wasted a lot of time
already and don't want to hold up the 1.18 release any longer than necessary.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 15 May 2025 11:28:55 +0000
Gerrit-HasComments: Yes
