Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22925 )
Change subject: WIP KUDU-1261 introduce nested types for ColumnSchemaPB ...................................................................... Patch Set 2: (1 comment) Thanks for the explanation. I think the overall idea of defining a new NESTED DataType and a new message to store all the details of NestedDataType has enough room for extending the Complex Types in future. http://gerrit.cloudera.org:8080/#/c/22925/2/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/22925/2/src/kudu/common/common.proto@152 PS2, Line 152: optional bytes read_default_value = 6; : optional bytes write_default_value = 7; > As I understand, there is no need to extend these since their format is uni Sounds good! -- To view, visit http://gerrit.cloudera.org:8080/22925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf5f32c4291e7906ffb68070bee0d5369fab36fd Gerrit-Change-Number: 22925 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 May 2025 19:57:14 +0000 Gerrit-HasComments: Yes
