Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22925 )
Change subject: WIP KUDU-1261 introduce nested types for ColumnSchemaPB ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22925/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/22925/1/src/kudu/common/common.proto@63 PS1, Line 63: NESTED > You meant placing some sort of field into ColumnTypeAttributesPB instead of Okay makes sense, agreed. http://gerrit.cloudera.org:8080/#/c/22925/1/src/kudu/common/common.proto@73 PS1, Line 73: add the ' I guess we would be having some conditions in place to ensure this can't be declared as DataType NESTED, right? http://gerrit.cloudera.org:8080/#/c/22925/2/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/22925/2/src/kudu/common/common.proto@152 PS2, Line 152: optional bytes read_default_value = 6; : optional bytes write_default_value = 7; Any thoughts on how to extend these to array datatype? Are we using the same idea as detailed in the design https://gerrit.cloudera.org/#/c/22058 or any other way? -- To view, visit http://gerrit.cloudera.org:8080/22925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf5f32c4291e7906ffb68070bee0d5369fab36fd Gerrit-Change-Number: 22925 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 May 2025 19:08:10 +0000 Gerrit-HasComments: Yes
