Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22822 )
Change subject: WIP KUDU-1457: IPv6 support for Kudu ...................................................................... Patch Set 1: (1 comment) look http://gerrit.cloudera.org:8080/#/c/22822/1/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/22822/1/src/kudu/util/net/net_util.cc@188 PS1, Line 188: vector<string> p = strings::Split(str, ":"); an idea to make this a bit simpler: for the bracket_right != string::npos case the string could be split by "]", so there would be 2 parts in both ipv4 and ipv6 case, then for ipv6 for both parts the first char would need to be dropped. -- To view, visit http://gerrit.cloudera.org:8080/22822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab9225f7465a647876670562e4dee3911e3208a9 Gerrit-Change-Number: 22822 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 29 May 2025 15:50:19 +0000 Gerrit-HasComments: Yes
