Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22822 )
Change subject: WIP KUDU-1457: IPv6 support for Kudu ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22822/1/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/22822/1/src/kudu/util/net/net_util.cc@188 PS1, Line 188: vector<string> p = strings::Split(str, ":"); > an idea to make this a bit simpler: for the bracket_right != string::npos c Yes, I have made it simpler in my local workspace. There are a number of scenarios there, for example: 1. IPv4 - If number of colons is 0, no port is specified e.g. 192.168.1.1 2. IPv4 - If number of colons is 1, a port is specified e.g. 192.168.1.1:1024 3. If number of colons is > 1 - IPv6 address doesn't contain any brackets i.e. no port is specified (fe80::d28d:603:9a20:ccf4) - IPv6 address format with without port [fe80::d28d:603:9a20:ccf4] - IPv6 address format with without port [fe80::d28d:603:9a20:ccf4]:1024 I need to validate, though, whether cases without ports would be even applicable in the first place. For impala, is "no port" specified a valid use case? -- To view, visit http://gerrit.cloudera.org:8080/22822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab9225f7465a647876670562e4dee3911e3208a9 Gerrit-Change-Number: 22822 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 29 May 2025 16:13:35 +0000 Gerrit-HasComments: Yes
