Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts ...................................................................... Patch Set 2: (1 comment) Overall looks good to me. Just a minor nit. http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh@43 PS2, Line 43: custom_run_at_rocky9 Should we just make it run for any rocky version for now? There is a likelihood that same rules apply for next version as well. Later, if we find that build for future version is failing, we can have separate handling for that version. What do you say? -- To view, visit http://gerrit.cloudera.org:8080/23033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d Gerrit-Change-Number: 23033 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Jun 2025 06:01:21 +0000 Gerrit-HasComments: Yes
