Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22977 )

Change subject: [arm64] Fix SIGBUS errors for atomic operations
......................................................................


Patch Set 2:

Hi!

I managed to reproduce the test failure.
The tree seems to work fine, the problem is with the unit test itself, you 
should fix it:
https://github.com/apache/kudu/compare/master...martonka:kudu_wd:cbtree_fix

The nodes are guaranteed to be aligned by AllocateBytesAligned.
However in the unit test you have to tell clang to allocate the node on the 
stack with alignas (8) too.

Please add alignas(atomic_alignment) to the 5 places in cbtree-test.cc where we 
create a  leaf/internal node and you should be fine.

The end of structure is truncated for performance reasons, which are measurable 
on ARM too.


--
To view, visit http://gerrit.cloudera.org:8080/22977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8ea46308f942ded97d93d27ae466fd13a31b53
Gerrit-Change-Number: 22977
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Wed, 18 Jun 2025 13:31:53 +0000
Gerrit-HasComments: No

Reply via email to