Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22977 )
Change subject: [arm64] Fix SIGBUS errors for atomic operations ...................................................................... Patch Set 1: > Hi! > > I managed to reproduce the test failure. > The tree seems to work fine, the problem is with the unit test > itself, you should fix it: > https://github.com/apache/kudu/compare/master...martonka:kudu_wd:cbtree_fix > > The nodes are guaranteed to be aligned by AllocateBytesAligned. > However in the unit test you have to tell clang to allocate the > node on the stack with alignas (8) too. > > Please add alignas(atomic_alignment) to the 5 places in > cbtree-test.cc where we create a leaf/internal node and you should > be fine. > > The end of structure is truncated for performance reasons, which > are measurable on ARM too. Great! Thanks for doing proper RCA for this issue, Zoltan! It explains why there was SIGBUG while running cbtree-test, but not many other tests where the concurrent BTree is also involved when processing inserts/updates. -- To view, visit http://gerrit.cloudera.org:8080/22977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f8ea46308f942ded97d93d27ae466fd13a31b53 Gerrit-Change-Number: 22977 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 19 Jun 2025 04:36:14 +0000 Gerrit-HasComments: No
