Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23065 )
Change subject: [build] kudu-replication and kudu-hive jar fix ...................................................................... Patch Set 3: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/23065/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23065/3//COMMIT_MSG@6 PS3, Line 6: nit: I think you can also mention that these changes are need because the verify_jars.pl was not being utilised properly for a while. (just to give more context for other reviewers) http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-hive/build.gradle File java/kudu-hive/build.gradle: http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-hive/build.gradle@61 PS3, Line 61: exclude(dependency("org.apache.hive::.*")) : exclude(dependency("org.apache.kerby:.*")) question: why are we using ':.*' in some places and '::.*' in others? http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-hive/build.gradle@87 PS3, Line 87: exclude 'org/apache/log4j/**' do we need this, as log4j is excluded above on the dependency level? http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-replication/build.gradle File java/kudu-replication/build.gradle: http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-replication/build.gradle@36 PS3, Line 36: exclude "META-INF/licenses/**" : exclude "META-INF/services/org.apache.flink.*" : exclude "assets/**" : exclude "com/esotericsoftware/**" : exclude "flink-jaas.conf" : exclude "flink-rpc-akka.jar" : exclude "javax/annotation/**" : exclude "one/profiler/**" : exclude "org/snakeyaml/**" Shouldn't the path based excludes live outside the dependency group? -- To view, visit http://gerrit.cloudera.org:8080/23065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e07bd8190be5973acf88c806c63060a3098007b Gerrit-Change-Number: 23065 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 23 Jun 2025 16:34:02 +0000 Gerrit-HasComments: Yes
