Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23065 )
Change subject: [build] Jar exlusion fixes ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/23065/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23065/3//COMMIT_MSG@6 PS3, Line 6: > nit: I think you can also mention that these changes are need because the Done http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-hive/build.gradle File java/kudu-hive/build.gradle: http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-hive/build.gradle@61 PS3, Line 61: exclude(dependency("org.apache.thrift::.*")) : exclude(dependency("org.codehaus.jackson:: > question: why are we using ':.*' in some places and '::.*' in others? the notation used is "<group>:<artifact>:<version>", where if you leave the artifact part empty, it will match for all artifacts in the specified group, so it should always be '::.*' (where .* is the match all regex pattern for all versions), so the ":.*" lines should be "::.*" but it seems they don't break the verification anywhere, still I'm fixing these http://gerrit.cloudera.org:8080/#/c/23065/3/java/kudu-hive/build.gradle@87 PS3, Line 87: // kudu-hive has no public Java > do we need this, as log4j is excluded above on the dependency level? we need this, we actually don't need the ones above, fixed -- To view, visit http://gerrit.cloudera.org:8080/23065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e07bd8190be5973acf88c806c63060a3098007b Gerrit-Change-Number: 23065 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 24 Jun 2025 13:53:41 +0000 Gerrit-HasComments: Yes
