Hello Marton Greber, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23063
to look at the new patch set (#2).
Change subject: [thrift] Silence Thrift compiler warnings by redirecting
......................................................................
[thrift] Silence Thrift compiler warnings by redirecting
This change updates the CMake `THRIFT_GENERATE_CPP` function to redirect
both stdout and stderr (`> /dev/null 2>&1`) when invoking the Thrift
compiler. This ensures that warnings like:
[WARNING:/data/code/kudu/src/kudu/hms/hive_metastore.thrift:2184]
No field key specified for o2, resulting protocol may have conflicts or not
be backwards compatible!
are no longer shown in the build output.
Note: The warning originates from `hive_metastore.thrift`, which is copied
from the Apache Hive project. For compatibility reasons, we cannot modify
the original `.thrift` file.
This change only hides warnings from the logs. To ensure full protocol
compatibility, it is still recommended to assign explicit field IDs in
`.thrift` files when possible.
Change-Id: Ifdb8b650f9b8ed1cdea9dd0cf1a80ef264ccc7d7
---
M cmake_modules/FindThrift.cmake
1 file changed, 15 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/23063/2
--
To view, visit http://gerrit.cloudera.org:8080/23063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifdb8b650f9b8ed1cdea9dd0cf1a80ef264ccc7d7
Gerrit-Change-Number: 23063
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
